Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.13 to CI #3103

Merged
merged 42 commits into from
Dec 10, 2024
Merged

Add Python 3.13 to CI #3103

merged 42 commits into from
Dec 10, 2024

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Oct 1, 2024 •
edited
Loading

Needs #3268 (or at least the Docker images updated manually).

UPDATE: Docker images have been updated!

UPDATE 2 needs the following:

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.05%. Comparing base (00ba007) to head (0c8ea49).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3103   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files         571      571           
  Lines      111080   111080           
=======================================
  Hits        74489    74489           
  Misses      36591    36591

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran JCGoran mentioned this pull request Oct 3, 2024
Closed
@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran JCGoran mentioned this pull request Oct 28, 2024
Merged
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran
Fix issue on Python 3.13.1
9821eaf 
For some reason, python/cpython#125846 broke the
ability to iterate over `HocObject`s, so as a workaround, we can first
cast it to a Python list.
nrnhines
nrnhines approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions optional.

test/hoctests/tests/test_thread_partition.py Outdated Show resolved Hide resolved
test/pytest_coreneuron/test_basic.py Outdated Show resolved Hide resolved
test/pytest_coreneuron/test_zptrlist.py Outdated Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran JCGoran changed the title Test CI for Python 3.13 Add Python 3.13 support Dec 9, 2024
@JCGoran JCGoran linked an issue Dec 9, 2024 that may be closed by this pull request
Python 3.13 support #2640
Closed
JCGoran
JCGoran commented Dec 9, 2024
View reviewed changes
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@JCGoran JCGoran marked this pull request as ready for review December 9, 2024 21:58
@bbpbuildbot

This comment has been minimized.

Sign in to view
@JCGoran
Update Dockerfile
95074a2 
Remove Python 3.13t (the free-threaded build) as we do not support it
yet.
@JCGoran JCGoran changed the title Add Python 3.13 support Add Python 3.13 to CI Dec 10, 2024
@azure-pipelines Azure Pipelines
Copy link

✔️ 95074a2 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #240205 (:no_entry:) have been uploaded here!

Status and direct links:

@azure-pipelines Azure Pipelines
Copy link

✔️ 0c8ea49 -> Azure artifacts URL

@JCGoran JCGoran merged commit de07242 into master Dec 10, 2024
38 checks passed
@JCGoran JCGoran deleted the jelic/test_313 branch December 10, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.13 support
3 participants
@JCGoran @bbpbuildbot @nrnhines